Re: [PATCH v2] clk: armada-370: fix tclk frequencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2013 at 08:23:07AM -0400, Jason Cooper wrote:
> Simon,
> 
> On Thu, Oct 03, 2013 at 12:05:02PM +0200, Simon Guinot wrote:
> > This patch fixes the tclk frequency array for the Armada-370 SoC.
> > This bug has been introduced by commit 6b72333d
> > ("clk: mvebu: add Armada 370 SoC-centric clock init").
> > 
> > A wrong tclk frequency affects the following drivers: mvsdio, mvneta,
> > i2c-mv64xxx and mvebu-devbus. This list may be incomplete.
> > 
> > About the mvneta Ethernet driver, note that the tclk frequency is used
> > to compute the Rx time coalescence. Then, this bug harms the coalescence
> > configuration and also degrades the networking performances with the
> > default values.
> > 
> > Signed-off-by: Simon Guinot <simon.guinot@xxxxxxxxxxxx>
> > Cc: Andrew Lunn <andrew@xxxxxxx>
> > Cc: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> > Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> >  drivers/clk/mvebu/armada-370.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Much better, thanks!
> 
> Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx>
> 
> This can be applied to v3.11 onwards.

Hi Mike,

Please consider applying this patch.

Thanks,

Simon

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]