This is a note to let you know that I've just added the patch titled iommu/arm-smmu: fix a signedness bug to the 3.11-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: iommu-arm-smmu-fix-a-signedness-bug.patch and it can be found in the queue-3.11 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From faea13b72dbdb77e4d6ad83344596486611708b0 Mon Sep 17 00:00:00 2001 From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Wed, 21 Aug 2013 09:33:30 +0100 Subject: iommu/arm-smmu: fix a signedness bug From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> commit faea13b72dbdb77e4d6ad83344596486611708b0 upstream. Unsigned char is never equal to -1. Tested-by: Will Deacon <will.deacon@xxxxxxx> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Will Deacon <will.deacon@xxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- drivers/iommu/arm-smmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -379,6 +379,7 @@ struct arm_smmu_cfg { u32 cbar; pgd_t *pgd; }; +#define INVALID_IRPTNDX 0xff struct arm_smmu_domain { /* @@ -830,7 +831,7 @@ static int arm_smmu_init_domain_context( if (IS_ERR_VALUE(ret)) { dev_err(smmu->dev, "failed to request context IRQ %d (%u)\n", root_cfg->irptndx, irq); - root_cfg->irptndx = -1; + root_cfg->irptndx = INVALID_IRPTNDX; goto out_free_context; } @@ -855,7 +856,7 @@ static void arm_smmu_destroy_domain_cont if (!smmu) return; - if (root_cfg->irptndx != -1) { + if (root_cfg->irptndx != INVALID_IRPTNDX) { irq = smmu->irqs[smmu->num_global_irqs + root_cfg->irptndx]; free_irq(irq, domain); } Patches currently in stable-queue which might be from dan.carpenter@xxxxxxxxxx are queue-3.11/cciss-fix-info-leak-in-cciss_ioctl32_passthru.patch queue-3.11/iommu-arm-smmu-fix-a-signedness-bug.patch queue-3.11/cpqarray-fix-info-leak-in-ida_locked_ioctl.patch queue-3.11/asoc-max98095-a-couple-array-underflows.patch queue-3.11/iommu-arm-smmu-fix-iommu_present-test-in-init.patch queue-3.11/asoc-ab8500-codec-info-leak-in-anc_status_control_put.patch queue-3.11/net-sctp-fix-smatch-warning-in-sctp_send_asconf_del_ip.patch queue-3.11/asoc-88pm860x-array-overflow-in-snd_soc_put_volsw_2r_st.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html