Re: [PATCH] Bluetooth: btusb: Remove Yoga 920 from the btusb_needs_reset_resume_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



+ Leif

On Wed, Feb 28, 2018 at 2:57 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Commit 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA
> reset_resume quirking"), added the Lenovo Yoga 920 to the
> btusb_needs_reset_resume_table.
>
> Testing has shown that this is a false positive and the problems where
> caused by issues with the initial fix: commit fd865802c66b ("Bluetooth:
> btusb: fix QCA Rome suspend/resume"), which has already been reverted.
>
> So the QCA Rome BT in the Yoga 920 does not need a reset-resume quirk at
> all and this commit removes it from the btusb_needs_reset_resume_table.
>
> Note that after this commit the btusb_needs_reset_resume_table is now
> empty. It is kept around on purpose, since this whole series of commits
> started for a reason and there are actually broken platforms around,
> which need to be added to it.

This is hilarious.

I think we need to go back to the author(s) of commit fd865802c66b and
find proper details about said "numerous reported instances" of
problems... Anyway:

Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>

> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1514836
> Fixes: 55a9c95d70ab ("Bluetooth: btusb: Use DMI matching for QCA ...")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Brian Norris <briannorris@xxxxxxxxxxxx>
> Cc: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> Tested-by: Kevin Fenzi <kevin@xxxxxxxxx>
> Suggested-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/bluetooth/btusb.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index a4b62f0a93cc..418550eb1522 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -386,13 +386,6 @@ static const struct usb_device_id blacklist_table[] = {
>   * the module itself. So we use a DMI list to match known broken platforms.
>   */
>  static const struct dmi_system_id btusb_needs_reset_resume_table[] = {
> -       {
> -               /* Lenovo Yoga 920 (QCA Rome device 0cf3:e300) */
> -               .matches = {
> -                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> -                       DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 920"),
> -               },
> -       },
>         {}
>  };
>
> --
> 2.14.3
>



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]