On Sat, 24 Feb 2018 13:42:27 +0800 Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> wrote: > A memory block was allocated in intel_svm_bind_mm() but never freed > in a failure path. This patch fixes this by free it to avoid memory > leakage. > looks good to me. Thanks, > Cc: Ashok Raj <ashok.raj@xxxxxxxxx> > Cc: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # v4.4+ > Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> > --- > drivers/iommu/intel-svm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c > index 35a408d..3d4b924 100644 > --- a/drivers/iommu/intel-svm.c > +++ b/drivers/iommu/intel-svm.c > @@ -396,6 +396,7 @@ int intel_svm_bind_mm(struct device *dev, int > *pasid, int flags, struct svm_dev_ pasid_max - 1, GFP_KERNEL); > if (ret < 0) { > kfree(svm); > + kfree(sdev); > goto out; > } > svm->pasid = ret; [Jacob Pan]