Re: [PATCH v2] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/22/2018 07:28 AM, Shawn Lin wrote:

Lets cast this multiply to u64 type which prevents overflow.

Tested-by: Vineet Gupta <Vineet.Gupta1@xxxxxxxxxxxx>
Fixes: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files

Signed-off-by: Evgeniy Didin <Evgeniy.Didin@xxxxxxxxxxxx>

CC: Alexey Brodkin <abrodkin@xxxxxxxxxxxx>
CC: Eugeniy Paltsev <paltsev@xxxxxxxxxxxx>
CC: Douglas Anderson <dianders@xxxxxxxxxxxx>
CC: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
CC: linux-kernel@xxxxxxxxxxxxxxx
CC: linux-snps-arc@xxxxxxxxxxxxxxxxxxx
Cc: <stable@xxxxxxxxxxxxxxx> #  9d9491a7da2a mmc: dw_mmc: Fix the DTO timeout calculation

The fix looks good to me, but the tags should be improved a bit:

Fixes: 9d9491a7da2a ("mmc: dw_mmc: Fix the DTO timeout calculation")

Ok, then perhaps use Reported-by tag to call out when/how issue was found.

Reported-by: ARC STAR 9001306872 HSDK, sdio: board crashes when copying big files

Cc: <stable@xxxxxxxxxxxxxxx>

Otherwise,
Reviewed-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]