Re: Patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN" has been added to the 4.15-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Tue, Feb 20, 2018 at 12:10:06PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
> 
> to the 4.15-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      mips-fix-typo-big_endian-to-cpu_big_endian.patch
> and it can be found in the queue-4.15 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.

FYI this will introduce the following harmless kconfig warnings which
are fixed by commit ec897569ad7d ("usb: Move USB_UHCI_BIG_ENDIAN_* out
of USB_SUPPORT"):

warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)

If anybody cares about such warnings, that patch could be applied also.

Thanks
James

> 
> 
> From 2e6522c565522a2e18409c315c49d78c8b74807b Mon Sep 17 00:00:00 2001
> From: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> Date: Wed, 17 Jan 2018 19:56:38 +0100
> Subject: MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
> 
> From: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> 
> commit 2e6522c565522a2e18409c315c49d78c8b74807b upstream.
> 
> MIPS_GENERIC selects some options conditional on BIG_ENDIAN which does
> not exist.
> 
> Replace BIG_ENDIAN with CPU_BIG_ENDIAN which is the correct kconfig
> name. Note that BMIPS_GENERIC does the same which confirms that this
> patch is needed.
> 
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>
> Reviewed-by: James Hogan <jhogan@xxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.9+
> Patchwork: https://patchwork.linux-mips.org/patch/18495/
> [jhogan@xxxxxxxxxx: Clean up commit message]
> Signed-off-by: James Hogan <jhogan@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> ---
>  arch/mips/Kconfig |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
>  	select SYS_SUPPORTS_MULTITHREADING
>  	select SYS_SUPPORTS_RELOCATABLE
>  	select SYS_SUPPORTS_SMARTMIPS
> -	select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> -	select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> -	select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> -	select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> +	select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> +	select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> +	select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> +	select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
>  	select USE_OF
>  	help
>  	  Select this to build a kernel which aims to support multiple boards,
> 
> 
> Patches currently in stable-queue which might be from clabbe.montjoie@xxxxxxxxx are
> 
> queue-4.15/mips-fix-typo-big_endian-to-cpu_big_endian.patch
> queue-4.15/crypto-sun4i_ss_prng-fix-return-value-of-sun4i_ss_prng_generate.patch

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]