Re: [PATCH v4.14 stable] powerpc: Fix DABR match on hash based

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 16, 2018 at 03:51:40PM +0530, Naveen N. Rao wrote:
> Naveen N. Rao wrote:
> > From: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > 
> > Commit 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page")
> > mistakenly dropped the DSISR_DABRMATCH bit from the mask of bit tested
> > to skip trying to hash a page.
> > 
> > As a result, the DABR matches would no longer be detected.
> > 
> > This adds it back. We open code it in the 2 places where it matters
> > rather than fold it into DSISR_BAD_FAULT_32S/64S because this isn't
> > technically a bad fault and while we would never hit it with the
> > current code, I prefer if page_fault_is_bad() didn't trigger on these.
> > 
> > Fixes: 398a719d34a1 ("powerpc/mm: Update bits used to skip hash_page")
> > Cc: stable@xxxxxxxxxxxxxxx # v4.14
> > Tested-by: Pedro Miraglia Franco de Carvalho <pedromfc@xxxxxxxxxx>
> > Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> 
> Not quite sure if this is required, but:
> Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>

Thanks, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]