On Fri, Feb 02, 2018 at 06:24:16PM +0000, Shaikh, Azhar wrote:
> Hi Greg,
>
>
> [1] is merged on the 4.15 stable tree. But this caused 2 issues:
> i. PS/2 keyboard and mouse were broken on an Intel Braswell system. The fix for this is [4].
> ii. There were some corner cases where TPM suspend was failing on Braswell systems. The fix for this is [2] and [3].
>
> The patch pointed out by you is [2].
> [3] is dependent on [2]. So to fix the issue on stable tree we will need [2], [3] and [4].
>
> [4] is not there yet on Linus's branch. I think it is queued for 4.16.
>
> [5] fixes compile time warning introduced in [3].
This email was crazy difficult to read and understand :(
Please, footnotes in emails are for things you can go back and look at
later, after reading the body of a message, not to try to understand
exactly what in the world is going on and what I am supposed to do with
something.
In the future, just put the git sha1 in the email text, no need to link
to anything, we all have zillions of copies of the kernel source on our
own machines. And sometimes we do not have reliable web access (emails
works great as store and forward.)
Just use the format:
c382babccba2 ("tpm_tis: Move ilb_base_addr to tpm_tis_data")
to describe a commit id, which can be easily obtained by doing:
git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"'
(hint, I have an alias for it so I don't have to ever type that again).
So, with all of that, I still have no idea what I am supposed to do
here. The patch that triggered this email is obviously not a stable
tree patch, as all it does is move code around, right? Is there
something else I should be doing here? What action do you want me to
take?
totally confused,
greg k-h