Re: [PATCH for-next] IB/core: Avoid a potential OOPs for an unused optional parameter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 01, 2018 at 12:31:06PM -0800, Dennis Dalessandro wrote:
> From: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
> 
> The ev_file is an optional parameter for CQ creation. If the parameter
> is not passed, the ev_file pointer will be NULL.  Using that pointer
> to set the cq_context will result in an OOPs.
> 
> Verify that ev_file is not NULL before using.
> 
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.14.x
> Fixes: 9ee79fce3642 ("IB/core: Add completion queue (cq) object actions")
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@xxxxxxxxx>
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
>  drivers/infiniband/core/uverbs_std_types.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Yep! I was testing this recently and didn't hit this bug, it only
becomes a crash if something tries to use the cq..

Jason



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]