Re: [PATCH] mm/kasan: Don't vfree() nonexistent vm_area.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 02/01/2018 10:57 PM, Matthew Wilcox wrote:
> On Thu, Feb 01, 2018 at 07:33:49PM +0300, Andrey Ryabinin wrote:
>> +	case MEM_OFFLINE: {
>> +		struct vm_struct *vm;
>> +
>> +		/*
>> +		 * Only hot-added memory have vm_area. Freeing shadow
>> +		 * mapped during boot would be tricky, so we'll just
>> +		 * have to keep it.
>> +		 */
>> +		vm = find_vm_area((void *)shadow_start);
>> +		if (vm)
>> +			vfree((void *)shadow_start);
>> +	}
> 
> This looks like a complicated way to spell 'is_vmalloc_addr' ...
> 

It's not. shadow_start is never vmalloc address.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]