Re: [PATCH 4.4 39/63] net: reevalulate autoflowlabel setting after sysctl setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-01-01 at 15:24 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Shaohua Li <shli@xxxxxx>
> 
> 
> [ Upstream commit 513674b5a2c9c7a67501506419da5c3c77ac6f08 ]
[...]
> Note, this changes behavior a little bit. Before commit 42240901f7c4
> (ipv6: Implement different admin modes for automatic flow labels), the
> autoflowlabel behavior of a sock isn't sticky, eg, if sysctl changes,
> existing connection will change autoflowlabel behavior. After that
> commit, autoflowlabel behavior is sticky in the whole life of the sock.
> With this patch, the behavior isn't sticky again.
[...]

I think the getsockopt() handling for IPV6_AUTOFLOWLABEL also needs to
be updated, as it will now return 0 unless the option has been
explicitly set.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]