Re: objtool patches needed in v4.14.y (and possibly older kernels)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 18, 2018 at 11:52:13AM -0800, Guenter Roeck wrote:
> On Thu, Jan 18, 2018 at 02:59:50PM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Jan 17, 2018 at 01:49:07PM -0800, Guenter Roeck wrote:
> > > Hi Greg,
> > > 
> > > please add the following patches to v4.14.y.
> > > 
> > > ce90aaf5cde4 objtool: Fix seg fault with clang-compiled objects
> > > e7e83dd3ff1d objtool: Fix Clang enum conversion warning
> > > 0f908ccbeca9 tools/objtool/Makefile: don't assume sync-check.sh is executable
> > > d89e426499cf objtool: Fix seg fault caused by missing parameter
> > > 
> > > They are needed to avoid problems when building v4.14.y with clang.
> > > It might be useful to apply the same patches to older kernels
> > > if/when retpoline related changes are applied to those kernels.
> > 
> > From what I can tell, these only are needed for 4.14, the 4.9 and 4.4
> > backports of repoline didn't backport the huge objtool changes to ORC.
> > So hopefully it's all good there, otherwise I'm sure someone from the
> > Android team will complain I broke building with CLANG :)
> > 
> 
> Unfortunately, the problem is much worse: The Google toolchain with retpoline
> support causes a crash with the latest version of objtool. No idea if that is
> an objtool problem or a compiler problem; it was introduced with 'objtool:
> Allow alternatives to be ignored'.
> 
> You might also want to add
> 
> 2a0098d70640  objtool: Fix seg fault with gold linker
> 
> but that has a Fixes: tag and might be in your queue already.

Nope, didn't catch that one, thanks for pointing it out.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]