On Mon, Jan 15, 2018 at 11:00:54AM -0600, Josh Poimboeuf wrote: > On Mon, Jan 15, 2018 at 12:55:11PM +0100, David Woodhouse wrote: > > On Mon, 2018-01-15 at 10:06 +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > This is a note to let you know that I've just added the patch titled > > > > > > objtool: Allow alternatives to be ignored > > > > > > to the 4.9-stable tree which can be found at: > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > objtool-allow-alternatives-to-be-ignored.patch > > > and it can be found in the queue-4.9 subdirectory. > > > > Hm... they aren't being ignored entirely. > > > > arch/x86/crypto/camellia-aesni-avx2-asm_64.o: warning: objtool: .altinstr_replacement+0xf: return instruction outside of a callable function > > > > Josh? > > This should fix it (to be applied on top): > > ---- > > From: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > Subject: [PATCH] objtool: Fix retpoline support for pre-ORC objtool > > Objtool 1.0 (pre-ORC) produces the following warning when it encounters > a retpoline: > > arch/x86/crypto/camellia-aesni-avx2-asm_64.o: warning: objtool: .altinstr_replacement+0xf: return instruction outside of a callable function > > That warning is meant to catch GCC bugs and missing ENTRY/ENDPROC > annotations, neither of which are applicable to alternatives. Silence > the warning for alternative instructions, just like objtool 2.0 already > does. > > Reported-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > --- > tools/objtool/builtin-check.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Wonderful! Thanks so much for this, it works great for me, now queued up. greg k-h