On Wed, Jan 10, 2018 at 09:03:18PM +0100, Jean Delvare wrote: > Hi Greg, > > On Wed, 10 Jan 2018 20:10:44 +0100, Greg KH wrote: > > Many thanks for the report, I've queued up 252714155f04 now. I don't > > think 4ee2ec1b1225 needs to be merged, unless the acpi maintainers think > > it is a good idea to do so. > > > > Rafael, any thoughts? > > FWIW we applied both in SUSE kernels. I did not make the decision but I > approve it. Having duplicated code in our kernel when there's only one > occurrence of the same code upstream looks dangerous. If there ever is > a bug fixed in that function and we backport the fix, you can be sure > that only one of the copies will get fixed and the bug will remain in > the other. Good idea, I've now queued it up as well, thanks. greg k-h