On Tue, Jan 09, 2018 at 03:24:40PM +0800, Dave Young wrote: > On 01/09/18 at 01:41pm, Baoquan He wrote: > > On 01/09/18 at 09:09am, Dave Young wrote: > > > > > As for the macro name, VMCOREINFO_SYMBOL_ARRAY sounds better. Yep, that's better. > > I still think using vmcoreinfo_append_str is better. Unless we replace > > all array variables with the newly added macro. > > > > vmcoreinfo_append_str("SYMBOL(mem_section)=%lx\n", > > (unsigned long)mem_section); > > I have no strong opinion, either change all array uses or just introduce > the macro and start to use it from now on if we have similar array > symbols. Do you need some action on my side or will you folks take care about this? -- Kirill A. Shutemov