Re: FAILED: patch "[PATCH] [media] em28xx: fix assignment of the eeprom data" failed to apply to 3.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Could it be that the same code in 3.11 commit
f813b5775b471b656382ae8f087bb34dc894261f was already backported ?

commit f813b5775b471b656382ae8f087bb34dc894261f
Author: Alban Browaeys <alban.browaeys@xxxxxxxxx>
Date:   Tue Jul 16 18:57:53 2013 -0300

    [media] em28xx: fix assignment of the eeprom data
    
    Set the config structure pointer to the eeprom data pointer (data,
    here eedata dereferenced) not the pointer to the pointer to
    the eeprom data (eedata itself).
    
    Signed-off-by: Alban Browaeys <prahal@xxxxxxxxx>
    Signed-off-by: Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx>
    Cc: stable@xxxxxxxxxxxxxxx      # for v3.10
    Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
    Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>

diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c
b/drivers/media/usb/em28xx/em28xx-i2c.c
index 4851cc2..c4ff973 100644
--- a/drivers/media/usb/em28xx/em28xx-i2c.c
+++ b/drivers/media/usb/em28xx/em28xx-i2c.c
@@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev,
unsigned bus,
 
        *eedata = data;
        *eedata_len = len;
-       dev_config = (void *)eedata;
+       dev_config = (void *)*eedata;
 
        switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
        case 0:

Best regards,
Alban

Le mardi 24 septembre 2013 à 15:57 -0700, gregkh@xxxxxxxxxxxxxxxxxxx a
écrit :
> The patch below does not apply to the 3.10-stable tree.
> If someone wants it applied there, or to any other stable or longterm
> tree, then please email the backport, including the original git commit
> id to <stable@xxxxxxxxxxxxxxx>.
> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 32bf7c6cdf63a6704822c81b7139c54ac1cbd6a1 Mon Sep 17 00:00:00 2001
> From: Alban Browaeys <alban.browaeys@xxxxxxxxx>
> Date: Tue, 16 Jul 2013 18:57:53 -0300
> Subject: [PATCH] [media] em28xx: fix assignment of the eeprom data
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> Set the config structure pointer to the eeprom data pointer (data,
> here eedata dereferenced) not the pointer to the pointer to
> the eeprom data (eedata itself).
> 
> Signed-off-by: Alban Browaeys <prahal@xxxxxxxxx>
> Signed-off-by: Frank Schfer <fschaefer.oss@xxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx      # for v3.10
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> 
> diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx-i2c.c
> index 4851cc2e..c4ff9739 100644
> --- a/drivers/media/usb/em28xx/em28xx-i2c.c
> +++ b/drivers/media/usb/em28xx/em28xx-i2c.c
> @@ -726,7 +726,7 @@ static int em28xx_i2c_eeprom(struct em28xx *dev, unsigned bus,
>  
>  	*eedata = data;
>  	*eedata_len = len;
> -	dev_config = (void *)eedata;
> +	dev_config = (void *)*eedata;
>  
>  	switch (le16_to_cpu(dev_config->chip_conf) >> 4 & 0x3) {
>  	case 0:
> 
> 
> !DSPAM:52421e0912562604915346!
> 


--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]