Hi Arnd, On Mon, 8 Jan 2018 14:16:25 +0100 Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot <bot@xxxxxxxxxxxx> wrote: > > > > stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) > > Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g5da3d9af3a4b/ > > Tree: stable-rc > > Branch: linux-4.4.y > > Git Describe: v4.4.110-18-g5da3d9af3a4b > > Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9 > > Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > Built: 4 unique architectures > > > > Build Failures Detected: > > > > arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05) > > cm_x300_defconfig FAIL > > mvebu_v7_defconfig FAIL > > pxa3xx_defconfig FAIL > > raumfeld_defconfig FAIL > > > > mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches > > > > Errors: > > drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value > > drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here > > Hi Greg, > > Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was > apparently backported in error, it looks like it should just be > dropped here in 4.4.y. > > The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific > ECC BCH support")', that commit was merged into v4.14, git tag --contains says commit 43bcfd2bb24a has been merged in 3.14. > so backporting the > fix further is probably not appropriate for 4.9 or earlier kernels either. > > The duplicate case statement only happens before linux-4.6, as commit > c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for partial chunks")' > removed a previous 'case READOOB' statement in this driver, so the build > regression appears only in 4.4 but not 4.9. Crap, I didn't notice the NAND_READOOB case was handled before 4.6. Still, the fix is needed, which means we'll have to revert this version and create a custom one for 4.4. Thanks for this report. Boris