Re: [PATCH 4.14 015/159] bitops: Add clear/set_bit32() to linux/bitops.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2017-12-27 at 13:48 +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 26, 2017 at 09:41:36PM +0000, Ben Hutchings wrote:
> > On Fri, 2017-12-22 at 09:45 +0100, Greg Kroah-Hartman wrote:
> > > 4.14-stable review patch.  If anyone has any objections, please let me know.
> > > 
> > > ------------------
> > > 
> > > From: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > > 
> > > commit cbe96375025e14fc76f9ed42ee5225120d7210f8 upstream.
> > > 
> > > Add two simple wrappers around set_bit/clear_bit() that accept
> > > the common case of an u32 array. This avoids writing
> > > casts in all callers.
> > 
> > These won't work correctly on big-endian 64-bit systems.  They are also
> > unsafe to use on u32 arrays with an odd length, on 64-bit systems.
> > This is why lib/bitmap.c has conversion functions for u32 arrays.
> 
> I end up deleteing these later in the patch series, just like upstream
> did, so all should be ok, right?

Ah, sorry, I didn't get that far.  The end result looks OK.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]