Re: [PATCH] mac80211: Fix addition of mesh configuration element

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 15, 2017 at 10:29:29AM +0100, Richard Schütz wrote:
> From: Ilan peer <ilan.peer@xxxxxxxxx>
> 
> commit 57629915d568c522ac1422df7bba4bee5b5c7a7c upstream.
> 
> The code was setting the capabilities byte to zero,
> after it was already properly set previously. Fix it.
> 
> The bug was found while debugging hwsim mesh tests failures
> that happened since the commit mentioned below.
> 
> Fixes: 76f43b4c0a93 ("mac80211: Remove invalid flag operations in mesh TSF synchronization")
> Signed-off-by: Ilan Peer <ilan.peer@xxxxxxxxx>
> Reviewed-by: Masashi Honma <masashi.honma@xxxxxxxxx>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>
> Signed-off-by: Richard Schütz <rschuetz@xxxxxxxxxxxxxx>
> ---
>  net/mac80211/mesh.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
> index cc2a63bd233f..9c23172feba0 100644
> --- a/net/mac80211/mesh.c
> +++ b/net/mac80211/mesh.c
> @@ -279,8 +279,6 @@ int mesh_add_meshconf_ie(struct ieee80211_sub_if_data *sdata,
>  	/* Mesh PS mode. See IEEE802.11-2012 8.4.2.100.8 */
>  	*pos |= ifmsh->ps_peers_deep_sleep ?
>  			IEEE80211_MESHCONF_CAPAB_POWER_SAVE_LEVEL : 0x00;
> -	*pos++ = 0x00;
> -
>  	return 0;
>  }
>  
> -- 
> 2.15.1


I'm sorry, I don't understand what you want done with this patch.  Why
send it to stable@?

confused,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]