On Wed, Dec 13 2017 at 6:02pm -0500, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote: > On Wed, 2017-12-13 at 17:57 -0500, Mike Snitzer wrote: > > I've had a fix for this staged in linux-next for a while. Will be > > sending it to Linus tomorrow, see: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.15&id=afc567a4977b2d798e05153dd131a3c8d4758c0c > > > > BTW, there was no need to cc: stable given that it'll get fixed in 4.15 > > (issue was introduced during the 4.15 merge). > > Had that patch already been posted on the dm-devel mailing list? If not, I > think that's unfortunate. There was an exchange on dm-devel about the issue, see: "[PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t" I staged a bogus fix initially and then a proper fix. > Anyway, would it be possible to elaborate the commit message? Others also > ran into this bug. See e.g. https://marc.info/?l=linux-block&m=151215418123126&w=2. No, I'm not rebasing at this point. Too much has stacked above it (not just 4.15, I've already staged a lot for 4.16). Not to mention, rebasing immediately before sending a pull request to Linus is a recipe for trouble. Mike