Re: [PATCH 4.9 037/109] dmaengine: stm32-dma: Set correct args number for DMA request from DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



add Pierre-yves Mordret

acked-by: Ludovic BARRE <ludovic.barre@xxxxxx>

On 12/07/2017 01:56 PM, Greg Kroah-Hartman wrote:
4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: M'boumba Cedric Madianga <cedric.madianga@xxxxxxxxx>


[ Upstream commit 7e96304d99477de1f70db42035071e56439da817 ]

This patch sets the right number of arguments to be used for DMA clients
which request channels from DT.

Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@xxxxxxxxx>
Reviewed-by: Ludovic BARRE <ludovic.barre@xxxxxx>
Signed-off-by: Vinod Koul <vinod.koul@xxxxxxxxx>
Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
  drivers/dma/stm32-dma.c |    7 ++-----
  1 file changed, 2 insertions(+), 5 deletions(-)

--- a/drivers/dma/stm32-dma.c
+++ b/drivers/dma/stm32-dma.c
@@ -976,21 +976,18 @@ static struct dma_chan *stm32_dma_of_xla
  	struct stm32_dma_chan *chan;
  	struct dma_chan *c;
- if (dma_spec->args_count < 3)
+	if (dma_spec->args_count < 4)
  		return NULL;
cfg.channel_id = dma_spec->args[0];
  	cfg.request_line = dma_spec->args[1];
  	cfg.stream_config = dma_spec->args[2];
-	cfg.threshold = 0;
+	cfg.threshold = dma_spec->args[3];
if ((cfg.channel_id >= STM32_DMA_MAX_CHANNELS) || (cfg.request_line >=
  				STM32_DMA_MAX_REQUEST_ID))
  		return NULL;
- if (dma_spec->args_count > 3)
-		cfg.threshold = dma_spec->args[3];
-
  	chan = &dmadev->chan[cfg.channel_id];
c = dma_get_slave_channel(&chan->vchan.chan);





[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]