Re: [PATCH] btrfs: Handle btrfs_set_extent_delalloc failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 05, 2017 at 04:10:59PM +0800, Qu Wenruo wrote:
> 
> 
> On 2017年12月05日 15:29, Nikolay Borisov wrote:
> > This function was introduced by 247e743cbe6e ("Btrfs: Use async helpers to deal
> > with pages that have been improperly dirtied") and it didn't do any error
> > handling then. This function might very well fail in ENOMEM situation, yet
> > it's not handled, this could lead to inconsistent state. So let's handle the
> > failure by setting the mapping error bit.
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx
> 
> Reviewed-by: Qu Wenruo <wqu@xxxxxxxx>
> 
> That's the only missing one. Nice catch.

You mean the only unhandled call of btrfs_set_extent_delalloc? There's
one more in relocate_file_extent_cluster.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]