Re: [PATCH] drm/bridge: analogix dp: Fix runtime PM state in get_modes() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Misha,

On 2017-12-05 15:06, Misha Komarovskiy wrote:
On Mon, Nov 27, 2017 at 6:40 AM, Archit Taneja <architt@xxxxxxxxxxxxxx> wrote:
On 11/21/2017 01:19 PM, Marek Szyprowski wrote:
get_modes() callback might be called asynchronously from the DRM core and
it is not synchronized with bridge_enable(), which sets proper runtime PM
state of the main DP device. Fix this by calling pm_runtime_get_sync()
before calling drm_get_edid(), which in turn calls drm_dp_i2c_xfer() and
analogix_dp_transfer() to ensure that main DP device is runtime active
when doing any access to its registers.
Looks good to me. Would be nice to get an ack from rockchip too. Will queue
it
to drm-misc-fixes (so that it's merged for 4.15-rc2) if no one has any
objections.
After this patch accepted to 4.15-rc2 any chances to have it also in
4.14 stable?

I tested it manualy and it fixes boot freeze on snow with 4.14.
If required,
Tested-by: Misha Komarovskiy <zombah@xxxxxxxxx>

The patch is tagged cc: stable, so it should automatically get into v4.14.y
series once it finally lands in v4.15-rcX series.

> ...

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]