On Mon, Sep 23, 2013 at 7:29 AM, Jonghwan Choi <jhbird.choi@xxxxxxxxx> wrote:
> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> This patch looks like it should be in the 3.11-stable tree, should we apply
> it?
I forgot to even consider marking this for -stable. It was found by
Coverity and I haven't seen any actual bug reports from users, so one
could argue that it's not "a real bug that bothers people" (from
Documentation/stable_kernel_rules.txt).
However, I think the bug will cause a BUG_ON() in remove_element() if
this path is ever exercised and I think the fix is obviously correct,
so my advice is to apply it to -stable.
> ------------------
>
> From: "Bjorn Helgaas <bhelgaas@xxxxxxxxxx>"
>
> commit adbe6991efd36104ac9eaf751993d35eaa7f493a upstream
>
> This fixes a copy and paste error introduced by 9f060e2231
> ("block: Convert integrity to bvec_alloc_bs()").
>
> Found by Coverity (CID 1020654).
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Acked-by: Kent Overstreet <koverstreet@xxxxxxxxxx>
> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx>
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
> fs/bio-integrity.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 8fb4291..45e944f 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> @@ -734,7 +734,7 @@ void bioset_integrity_free(struct bio_set *bs)
> mempool_destroy(bs->bio_integrity_pool);
>
> if (bs->bvec_integrity_pool)
> - mempool_destroy(bs->bio_integrity_pool);
> + mempool_destroy(bs->bvec_integrity_pool);
> }
> EXPORT_SYMBOL(bioset_integrity_free);
>
> --
> 1.8.1.2
>
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html