Re: [PATCH AUTOSEL for 4.14 30/51] irqchip/gic: Make quirks matching conditional on init return value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 23, 2017 at 08:50:03AM +0000, Marc Zyngier wrote:
>On 22/11/17 22:25, alexander.levin@xxxxxxxxxxx wrote:
>> From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>>
>> [ Upstream commit 9d111d49106b61f5a652d5418e85d8741b1a0427 ]
>>
>> As it turns out, the IIDR is not sufficient to distinguish between GICv3
>> implementations when it comes to enabling quirks. So update the prototype
>> of the init() hook to return a bool, and interpret a 'false' return value
>> as no match, in which case the 'enabling workaround' log message should
>> not be printed.
>>
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
>
>What is the point of backporting this patch? It's only use is to enable
>a workaround that is not a pre-4.15 candidate.
>
>Same for its equivalent in the 4.9 tree.

I missed that this is to support new hardware and that no such
hardware exists before 4.15. I'll drop it, thanks!

-- 

Thanks,
Sasha



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]