Re: [PATCH] KEYS: add missing permission check for request_key() destination

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] KEYS: add missing permission check for request_key() destination
From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 28 Nov 2017 10:13:01 +0000
Cc: dhowells@xxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Eric Biggers <ebiggers@xxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <20171120225830.96642-1-ebiggers3@gmail.com>
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Eric Biggers <ebiggers3@xxxxxxxxx> wrote:

> +		if (do_perm_check) {
> +			ret = key_permission(make_key_ref(dest_keyring, 1),
> +					     KEY_NEED_WRITE);

dest_keyring may be NULL at this point as alloc_uid() doesn't automatically
create keyrings.

David

Follow-Ups:
- Re: [PATCH] KEYS: add missing permission check for request_key() destination
  - From: Eric Biggers

References:
- [PATCH] KEYS: add missing permission check for request_key() destination
  - From: Eric Biggers

Prev by Date: Patch "xen: xenbus driver must not accept invalid transaction ids" has been added to the 3.18-stable tree
Next by Date: Re: Patch "e1000e: fix buffer overrun while the I219 is processing DMA transactions" has been added to the 4.14-stable tree
Previous by thread: [PATCH] KEYS: add missing permission check for request_key() destination
Next by thread: Re: [PATCH] KEYS: add missing permission check for request_key() destination
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]