From: Tobias Jordan <Tobias.Jordan@xxxxxxxxxxxxxx>
commit 7978db344719dab1e56d05e6fc04aaaddcde0a5e upstream.
The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
doesn't drop the reference to "np" on errors. Fix that.
Fixes: 274659029c9d (PM / OPP: Add support to parse "operating-points-v2" bindings)
Cc: 4.4 <stable@xxxxxxxxxxxxxxx> # 4.4
Signed-off-by: Tobias Jordan <Tobias.Jordan@xxxxxxxxxxxxxx>
[ VK: Improved commit log. ]
Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Reviewed-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/base/power/opp/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c
index b8e76f75073b..0b4190a1efaa 100644
--- a/drivers/base/power/opp/core.c
+++ b/drivers/base/power/opp/core.c
@@ -1199,6 +1199,7 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np)
if (ret) {
dev_err(dev, "%s: Failed to add OPP, %d\n", __func__,
ret);
++ of_node_put(np);
goto free_table;
}
}
--
2.15.0.194.g9af6a3dea062