Re: WTF: patch "[PATCH] MIPS: pci: Remove KERN_WARN instance inside the mt7620 driver" was seriously submitted to be applied to the 4.9-stable tree?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Mon, Nov 27, 2017 at 01:35:46PM +0100, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> The patch below was submitted to be applied to the 4.9-stable tree.
> 
> I fail to see how this patch meets the stable kernel rules as found at
> Documentation/process/stable-kernel-rules.rst.
> 
> I could be totally wrong, and if so, please respond to 
> <stable@xxxxxxxxxxxxxxx> and let me know why this patch should be
> applied.  Otherwise, it is now dropped from my patch queues, never to be
> seen again.

I should have adjusted the commit message. KERN_WARN doesn't exist so it
actually fixes a build error as well as switching to pr_warn().

Cheers
James

> 
> thanks,
> 
> greg k-h
> 
> ------------------ original commit in Linus's tree ------------------
> 
> From 8593b18ad348733b5d5ddfa0c79dcabf51dff308 Mon Sep 17 00:00:00 2001
> From: John Crispin <john@xxxxxxxxxxx>
> Date: Mon, 20 Feb 2017 10:29:43 +0100
> Subject: [PATCH] MIPS: pci: Remove KERN_WARN instance inside the mt7620 driver
> 
> Switch the printk() call to the prefered pr_warn() api.
> 
> Fixes: 7e5873d3755c ("MIPS: pci: Add MT7620a PCIE driver")
> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
> Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxx
> Cc: <stable@xxxxxxxxxxxxxxx> # 4.5+
> Patchwork: https://patchwork.linux-mips.org/patch/15321/
> Signed-off-by: James Hogan <jhogan@xxxxxxxxxx>
> 
> diff --git a/arch/mips/pci/pci-mt7620.c b/arch/mips/pci/pci-mt7620.c
> index 22e4c22e750b..1a0b80a1cc4a 100644
> --- a/arch/mips/pci/pci-mt7620.c
> +++ b/arch/mips/pci/pci-mt7620.c
> @@ -120,7 +120,7 @@ static int wait_pciephy_busy(void)
>  		else
>  			break;
>  		if (retry++ > WAITRETRY_MAX) {
> -			printk(KERN_WARN "PCIE-PHY retry failed.\n");
> +			pr_warn("PCIE-PHY retry failed.\n");
>  			return -1;
>  		}
>  	}
> 

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]