Re: Patch "ACPI / APEI: Remove arch_apei_flush_tlb_one()" has been added to the 4.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On 25/11/17 13:54, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     ACPI / APEI: Remove arch_apei_flush_tlb_one()
> 
> to the 4.9-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      acpi-apei-remove-arch_apei_flush_tlb_one.patch
> and it can be found in the queue-4.9 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.

I don't think this patch should applied to the stable trees:

This patch is cleanup following 'ACPI / APEI: Replace ioremap_page_range() with
fixmap', which failed to apply to this tree. Having this patch will lead to
build-breakage with exotic Kconfig options!


Thanks,

James

> From 4a75aeacda3c2455954596593d89187df5420d0a Mon Sep 17 00:00:00 2001
> From: James Morse <james.morse@xxxxxxx>
> Date: Mon, 6 Nov 2017 18:44:27 +0000
> Subject: ACPI / APEI: Remove arch_apei_flush_tlb_one()
> 
> From: James Morse <james.morse@xxxxxxx>
> 
> commit 4a75aeacda3c2455954596593d89187df5420d0a upstream.
> 
> Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on
> __set_pte_vaddr() to do the invalidation when called from clear_fixmap()
> Remove arch_apei_flush_tlb_one().
> 
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> Reviewed-by: Borislav Petkov <bp@xxxxxxx>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> ---
>  arch/x86/kernel/acpi/apei.c |    5 -----
>  include/acpi/apei.h         |    1 -
>  2 files changed, 6 deletions(-)
> 
> --- a/arch/x86/kernel/acpi/apei.c
> +++ b/arch/x86/kernel/acpi/apei.c
> @@ -55,8 +55,3 @@ void arch_apei_report_mem_error(int sev,
>  	apei_mce_report_mem_error(sev, mem_err);
>  #endif
>  }
> -
> -void arch_apei_flush_tlb_one(unsigned long addr)
> -{
> -	__flush_tlb_one(addr);
> -}
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -44,7 +44,6 @@ int erst_clear(u64 record_id);
>  
>  int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data);
>  void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
> -void arch_apei_flush_tlb_one(unsigned long addr);
>  
>  #endif
>  #endif
> 
> 
> Patches currently in stable-queue which might be from james.morse@xxxxxxx are
> 
> queue-4.9/acpi-apei-remove-arch_apei_flush_tlb_one.patch
> 




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]