On Wed, Nov 15, 2017 at 04:03:51AM +0000, Patrick Brünn wrote: > >From: Ben Hutchings [mailto:ben.hutchings@xxxxxxxxxxxxxxx] > >Sent: Dienstag, 14. November 2017 16:45 > >> 4.4-stable review patch. If anyone has any objections, please let me know. > >> > >> ------------------ > >> > >> From: Patrick Bruenn <p.bruenn@xxxxxxxxxxxx> > >> > >> > >> [ Upstream commit 8b649e426336d7d4800ff9c82858328f4215ba01 ] > >> > >> The pinmux configuration in device tree was different from manual > >> muxing in <u-boot>/board/freescale/mx53loco/mx53loco.c > >> All pins were configured as NO_PAD_CTL(1 << 31), which was fine as the > >> bootloader already did the correct pinmuxing for us. > >> But recently u-boot is migrating to reuse device tree files from the > >> kernel tree, so it seems to be better to have the correct pinmuxing in > >> our files, too. > >[...] > > > >Presumably u-boot will reuse the *upstream* device tree files, which > >implies this doesn't need to be fixed on stable branches. > > > >Ben. > I think Ben made a good point. It might be dangerous to change the pinmux > configuration for an Ethernet controller in stable kernels, just in case > anyone out there uses a hardware and bootloader with different muxing. > Shawn might be able to tell, if that is even possible. > In case there is at least a chance someone is using a different configuration, > I wouldn't backport this commit to any stable branch. Ok, thanks, now dropped from the 4.4-stable queue. greg k-h