Re: [PATCH 3.10-stable] drivers/rtc/rtc-max77686.c: Fix wrong register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/12/2013 11:16 AM, Jonghwan Choi wrote:
This patch looks like it should be in the 3.10-stable tree, should we apply
it?

Right. This patch is for bug-fix so in my opinion, it is necessary to apply.

Cheers,
Sangjung


------------------

From: "Sangjung Woo <sangjung.woo@xxxxxxxxxxx>"

commit 1748cbf7f7c464593232cde914f5a103181a83b5 upstream

Fix a read of the wrong register when checking whether the RTC timer has
reached the alarm time.

Signed-off-by: Sangjung Woo <sangjung.woo@xxxxxxxxxxx>
Signed-off-by: Myugnjoo Ham <myungjoo.ham@xxxxxxxxxxx>
Reviewed-by: Jonghwa Lee <jonghwa3.lee@xxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
---
  drivers/rtc/rtc-max77686.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c
index 771812d..3bb9401 100644
--- a/drivers/rtc/rtc-max77686.c
+++ b/drivers/rtc/rtc-max77686.c
@@ -240,9 +240,9 @@ static int max77686_rtc_read_alarm(struct device *dev,
struct rtc_wkalrm *alrm)
  	}
alrm->pending = 0;
-	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS1,
&val);
+	ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2,
&val);
  	if (ret < 0) {
-		dev_err(info->dev, "%s:%d fail to read status1 reg(%d)\n",
+		dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n",
  				__func__, __LINE__, ret);
  		goto out;
  	}

--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]