Re: Patch "PM / QoS: Fix default runtime_pm device resume latency" has been added to the 4.13-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 07, 2017 at 01:49:03AM +0100, Rafael J. Wysocki wrote:
> On 11/5/2017 3:44 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> >      PM / QoS: Fix default runtime_pm device resume latency
> > 
> > to the 4.13-stable tree which can be found at:
> >      http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >       pm-qos-fix-default-runtime_pm-device-resume-latency.patch
> > and it can be found in the queue-4.13 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@xxxxxxxxxxxxxxx> know about it.
> > 
> > 
> >  From 2a9a86d5c81389cd9afe6a4fea42c585733cd705 Mon Sep 17 00:00:00 2001
> > From: Tero Kristo <t-kristo@xxxxxx>
> > Date: Mon, 30 Oct 2017 09:10:46 +0200
> > Subject: PM / QoS: Fix default runtime_pm device resume latency
> > 
> > From: Tero Kristo <t-kristo@xxxxxx>
> > 
> > commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 upstream.
> > 
> > The recent change to the PM QoS framework to introduce a proper
> > no constraint value overlooked to handle the devices which don't
> > implement PM QoS OPS.  Runtime PM is one of the more severely
> > impacted subsystems, failing every attempt to runtime suspend
> > a device.  This leads into some nasty second level issues like
> > probe failures and increased power consumption among other
> > things.
> > 
> > Fix this by adding a proper return value for devices that don't
> > implement PM QoS.
> > 
> > Fixes: 0cc2b4e5a020 (PM / QoS: Fix device resume latency PM QoS)
> > Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > ---
> >   include/linux/pm_qos.h |    3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > --- a/include/linux/pm_qos.h
> > +++ b/include/linux/pm_qos.h
> > @@ -175,7 +175,8 @@ static inline s32 dev_pm_qos_requested_f
> >   static inline s32 dev_pm_qos_raw_read_value(struct device *dev)
> >   {
> >   	return IS_ERR_OR_NULL(dev->power.qos) ?
> > -		0 : pm_qos_read_value(&dev->power.qos->resume_latency);
> > +		PM_QOS_RESUME_LATENCY_NO_CONSTRAINT :
> > +		pm_qos_read_value(&dev->power.qos->resume_latency);
> >   }
> >   #else
> >   static inline enum pm_qos_flags_status __dev_pm_qos_flags(struct device *dev,
> > 
> > 
> > Patches currently in stable-queue which might be from t-kristo@xxxxxx are
> > 
> > queue-4.13/pm-qos-fix-default-runtime_pm-device-resume-latency.patch
> 
> Please drop this from the -stable queue, it has been reverted from the
> mainline.

Ah, thanks for letting me know, now dropped.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]