On Fri, 2017-05-05 at 21:46 +0200, Arnd Bergmann wrote:
> From: James Bottomley <JBottomley@xxxxxxxx>
>
> Commit e03c2da6574223081b786960e39c1e5ecf5d492d upstream.
>
> non-x86 builds want the #warning in the IPS code about compiling on the wrong
> architecture removed because it keeps triggering on their platforms build
> farms. Transform from a compile time warning into a runtime one with taint to
> preserve the original intent of the authors.
I'll apply this, but:
[...]
> @@ -6789,6 +6785,11 @@ ips_remove_device(struct pci_dev *pci_dev)
> static int __init
> ips_module_init(void)
> {
> +#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)
> + printk(KERN_ERR "ips: This driver has only been tested on the x86/ia64/x86_64 platforms\n");
> + add_taint(TAINT_CPU_OUT_OF_SPEC, LOCKDEP_STILL_OK);
> +#endif
[...]
This is not the right taint flag to use.
Documentation/sysctl/kernel.txt says:
4 - Unsafe SMP processors: SMP with CPUs not designed for SMP.
Ben.
--
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert
Einstein
Attachment:
signature.asc
Description: This is a digitally signed message part