Hi Marek,
2017년 11월 02일 15:51에 Marek Szyprowski 이(가) 쓴 글:
> Hi Inki,
>
> On 2017-11-01 07:31, Inki Dae wrote:
>> 2017년 11월 01일 01:28에 Marek Szyprowski 이(가) 쓴 글:
>>> When no IOMMU is available, all GEM buffers allocated by Exynos DRM driver
>>> are contiguous, because of the underlying dma_alloc_attrs() function
>>> provides only such buffers. In such case it makes no sense to keep
>>> BO_NONCONTIG flag for the allocated GEM buffers. This allows to avoid
>>> failures for buffer contiguity checks in the subsequent operations on GEM
>>> objects.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
>>> CC: stable@xxxxxxxxxxxxxxx # v4.4+
>>> ---
>>> This issue is there since commit 0519f9a12d011 ("drm/exynos: add iommu
>>> support for exynos drm framework"), but this patch applies cleanly
>>> only to v4.4+ kernel releases due changes in the surrounding code.
>>> ---
>>> drivers/gpu/drm/exynos/exynos_drm_gem.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c
>>> index 02f978bb9261..476c00fe1998 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c
>>> @@ -227,6 +227,13 @@ struct exynos_drm_gem *exynos_drm_gem_create(struct drm_device *dev,
>>> if (IS_ERR(exynos_gem))
>>> return exynos_gem;
>>> + /*
>>> + * when no IOMMU is available, all allocated buffers are contiguous
>>> + * anyway, so drop EXYNOS_BO_NONCONTIG flag
>>> + */
>>> + if (!is_drm_iommu_supported(dev))
>>> + flags &= ~EXYNOS_BO_NONCONTIG;
>> Even through iommu isn't supported, there could be 3D GPU or other DMA devices which support IOMMU. Of course, in this case, at least one memory copy will be required to pass it to Display controller.
>> So I'm not clear yet and it would bring more dicussions here.
>
> This is NONCONTIG flag drop is done only in exynos_drm_gem_create() function,
Ah, sorry. it's NONCONTIG, not CONTIG. there was my mistaken.
Thanks,
Inki Dae
> which always allocates memory using dma_alloc_attrs() (a replacement for
> dma_alloc_coherent). There is no point keeping this flag, when we KNOW that
> the buffer is contiguous.
>
> For buffers shared from 3D GPU or other DMA device, GEM object will be created
> using exynos_drm_gem_prime_import() and exynos_drm_gem_prime_import_sg_table()
> functions, which checks for buffer contiguity and sets proper flags.
>
> Best regards