Re: [PATCH] arm: ensure dump_instr() checks addr_limit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 02, 2017 at 04:34:52PM +0000, Mark Rutland wrote:
> Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>

Huh?  What's that doing up here?

> When CONFIG_DEBUG_USER is enabled, it's possible for a user to
> deliberately trigger dump_instr() with a chosen kernel address.
> 
> Let's avoid problems resulting from this by using get_user() rather than
> __get_user(), ensuring that we don't erroneously access kernel memory.
> 
> So that we can use the same code to dump user instructions and kernel
> instructions, the common dumping code is factored out to __dump_instr(),
> with the fs manipulated appropriately in dump_instr() around calls to
> this.
> 
> Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

It's right here...

confused.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]