On Tue, Oct 31, 2017 at 04:54:56PM +0000, Gal Shalif wrote: > From 436a7eb28215081d34c386a92213bd6932d0779a Mon Sep 17 00:00:00 2001 > From: Gal Shalif <gals@xxxxxxxx> > Date: Tue, 31 Oct 2017 18:00:36 +0200 > Subject: [PATCH] USB: serial: option: add Novatel USB730L enterprise mode > > Add the serial interface of the Novatel USB730L > enterprise mode. > Change is done according to: > Novatel Linux Integration Guide for USB730L at: > https://www.verizonwireless.com/dam/support/pdf/verizon-usb730l-integration-guide.pdf > > Signed-off-by: Gal Shalif <gal@xxxxxxxxxx> Your SoB should match the From: field. > Cc: Gal Shalif Work <gals@xxxxxxxx> > Cc: Bjorn Mork <bjorn@xxxxxxx> > Cc: Oliver Neukum <oneukum@xxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx> And you must never add someone else's SoB (I'll add that myself when I apply the patch). > --- > drivers/usb/serial/option.c | 2 ++ Also this is a p0 patch so fails to apply without some manual intervention. You could try using git-format-patch and git-send-email and send the patch to yourself first to make sure it applies using git-am. > 1 file changed, 2 insertions(+) > > diff --git drivers/usb/serial/option.c drivers/usb/serial/option.c > index ba672cf..5ea9fa5 100644 > --- drivers/usb/serial/option.c > +++ drivers/usb/serial/option.c > @@ -162,6 +162,7 @@ static void option_instat_callback(struct urb *urb); > #define NOVATELWIRELESS_PRODUCT_E362 0x9010 > #define NOVATELWIRELESS_PRODUCT_E371 0x9011 > #define NOVATELWIRELESS_PRODUCT_U620L 0x9022 > +#define NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L 0x9032 > #define NOVATELWIRELESS_PRODUCT_G2 0xA010 > #define NOVATELWIRELESS_PRODUCT_MC551 0xB001 > > @@ -1121,6 +1122,7 @@ static const struct usb_device_id option_ids[] = { > { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E362, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_E371, 0xff, 0xff, 0xff) }, > { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_U620L, 0xff, 0x00, 0x00) }, > + { USB_DEVICE_AND_INTERFACE_INFO(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_ENTERPRISE_U730L, 0xff, 0x00, 0x00) }, > > { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01) }, > { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_H01A) }, Other than that, this looks to good to me. Perhaps you could include the output of usb-devices for reference as well. Care to send a v2 with the right Signed-off-by? Thanks, Johan