Re: [GIT PULL] tracing/samples: Fix creation and deletion of simple_thread_fn creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm back home, which means I do full builds, and that in turn shows
that this was garbage.

On Tue, Oct 17, 2017 at 2:21 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> Please pull the latest trace-v4.14-rc3 tree, which can be found at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> trace-v4.14-rc3

This causes a compiler warning, for a very valid reason:

> +static bool simple_thread_cnt;
>
>  int foo_bar_reg(void)
>  {
> +       mutex_lock(&thread_mutex);
> +       if (simple_thread_cnt++)
> +               goto out;

Yeah., take a closer look at that. It's complete and utter BS.

Please send a fix asap, or I'll just revert.

                     Linus



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]