This is a note to let you know that I've just added the patch titled [PATCH] Revert "bsg-lib: don't free job in bsg_prepare_job" to the 4.9-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: revert-bsg-lib-don-t-free-job-in-bsg_prepare_job.patch and it can be found in the queue-4.9 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 42fbb07e2e3a338154ee747bf28dc688bc599b81 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Date: Thu, 19 Oct 2017 14:55:29 +0200 Subject: [PATCH] Revert "bsg-lib: don't free job in bsg_prepare_job" This reverts commit eb4375e1969c48d454998b2a284c2e6a5dc9eb68 which was commit f507b54dccfd8000c517d740bc45f20c74532d18 upstream. Ben reports: That function doesn't exist here (it was introduced in 4.13). Instead, this backport has modified bsg_create_job(), creating a leak. Please revert this on the 3.18, 4.4 and 4.9 stable branches. So I'm dropping it from here. Reported-by: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx> Cc: Christoph Hellwig <hch@xxxxxx> Cc: Ming Lei <ming.lei@xxxxxxxxxx> Cc: Jens Axboe <axboe@xxxxxxxxx> Signed-off-by: Greg Kroah-Hartman gregkh@xxxxxxxxxxxxxxxxxxx --- block/bsg-lib.c | 1 + 1 file changed, 1 insertion(+) --- a/block/bsg-lib.c +++ b/block/bsg-lib.c @@ -147,6 +147,7 @@ static int bsg_create_job(struct device failjob_rls_rqst_payload: kfree(job->request_payload.sg_list); failjob_rls_job: + kfree(job); return -ENOMEM; } Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are queue-4.9/net-mlx4_core-fix-vf-overwrite-of-module-param-which-disables-dmfs-on-new-probed-pfs.patch queue-4.9/scsi-scsi_dh_emc-return-success-in-clariion_std_inquiry.patch queue-4.9/mac80211-fix-power-saving-clients-handling-in-iwlwifi.patch queue-4.9/mips-fix-minimum-alignment-requirement-of-irq-stack.patch queue-4.9/qede-prevent-index-problems-in-loopback-test.patch queue-4.9/net-mvpp2-release-reference-to-txq_cpu-entry-after-unmapping.patch queue-4.9/uapi-fix-linux-mroute6.h-userspace-compilation-errors.patch queue-4.9/irqchip-crossbar-fix-incorrect-type-of-local-variables.patch queue-4.9/watchdog-kempld-fix-gcc-4.3-build.patch queue-4.9/md-linear-shutup-lockdep-warnning.patch queue-4.9/edac-mce_amd-print-ipid-and-syndrome-on-a-separate-line.patch queue-4.9/qed-reserve-doorbell-bar-space-for-present-cpus.patch queue-4.9/btmrvl-avoid-double-disable_irq-race.patch queue-4.9/revert-bsg-lib-don-t-free-job-in-bsg_prepare_job.patch queue-4.9/mm-memory_hotplug-set-magic-number-to-page-freelist-instead-of-page-lru.next.patch queue-4.9/netfilter-nf_ct_expect-change-__nf_ct_expect_check-return-value.patch queue-4.9/nfsd-callback-cleanup-callback-cred-on-shutdown.patch queue-4.9/ocfs2-dlmglue-prepare-tracking-logic-to-avoid-recursive-cluster-lock.patch queue-4.9/iio-adc-xilinx-fix-error-handling.patch queue-4.9/uapi-fix-linux-rds.h-userspace-compilation-errors.patch queue-4.9/ib-hfi1-use-static-ctle-with-preset-6-for-integrated-hfis.patch queue-4.9/initramfs-finish-fput-before-accessing-any-binary-from-initramfs.patch queue-4.9/crypto-xts-add-ecb-dependency.patch queue-4.9/target-iscsi-fix-unsolicited-data-seq_end_offset-calculation.patch queue-4.9/btrfs-send-fix-failure-to-rename-top-level-inode-due-to-name-collision.patch queue-4.9/net-mlx4_en-fix-overflow-in-mlx4_en_init_timestamp.patch queue-4.9/ceph-fix-bogus-endianness-change-in-ceph_ioctl_set_layout.patch queue-4.9/asoc-mediatek-add-i2c-dependency-for-cs42xx8.patch queue-4.9/sched-fair-update-rq-clock-before-changing-a-task-s-cpu-affinity.patch queue-4.9/slub-do-not-merge-cache-if-slub_debug-contains-a-never-merge-flag.patch queue-4.9/qed-read-queue-state-before-releasing-buffer.patch queue-4.9/regulator-core-resolve-supplies-before-disabling-unused-regulators.patch queue-4.9/i2c-at91-ensure-state-is-restored-after-suspending.patch queue-4.9/alsa-hda-add-geminilake-hdmi-codec-id.patch queue-4.9/drm-amdgpu-refuse-to-reserve-io-mem-for-split-vram-buffers.patch queue-4.9/xen-netback-use-gfp_atomic-to-allocate-hash.patch queue-4.9/mac80211_hwsim-check-hwsim_attr_radio_name-length.patch queue-4.9/cpufreq-cppc-add-acpi_processor-dependency.patch queue-4.9/f2fs-do-ssr-for-data-when-there-is-enough-free-space.patch queue-4.9/ceph-clean-up-unsafe-d_parent-accesses-in-build_dentry_path.patch queue-4.9/ib-hfi1-allocate-context-data-on-memory-node.patch queue-4.9/f2fs-do-not-wait-for-writeback-in-write_begin.patch queue-4.9/powerpc-perf-add-restrictions-to-pmc5-in-power9-dd1.patch queue-4.9/drm-nouveau-gr-gf100-fix-ccache-error-logging.patch queue-4.9/sparc64-migrate-hvcons-irq-to-panicked-cpu.patch queue-4.9/staging-vchiq_2835_arm-make-cache-line-size-a-required-dt-property.patch queue-4.9/locking-lockdep-add-nest_lock-integrity-test.patch queue-4.9/ceph-don-t-update_dentry_lease-unless-we-actually-got-one.patch queue-4.9/hrtimer-catch-invalid-clockids-again.patch queue-4.9/qed-don-t-use-attention-ptt-for-configuring-bw.patch