Re: [PATCH v3.16.y] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2017 at 02:40:22PM +0100, Mark Rutland wrote:
> Commit e88d62cd4b2f0b1ae55e9008e79c2794b1fc914d upstream.
> 
> As raw_cpu_generic_read() is a plain read from a raw_cpu_ptr() address,
> it's possible (albeit unlikely) that the compiler will split the access
> across multiple instructions.
> 
> In this_cpu_generic_read() we disable preemption but not interrupts
> before calling raw_cpu_generic_read(). Thus, an interrupt could be taken
> in the middle of the split load instructions. If a this_cpu_write() or
> RMW this_cpu_*() op is made to the same variable in the interrupt
> handling path, this_cpu_read() will return a torn value.
> 
> For native word types, we can avoid tearing using READ_ONCE(), but this
> won't work in all cases (e.g. 64-bit types on most 32-bit platforms).
> This patch reworks this_cpu_generic_read() to use READ_ONCE() where
> possible, otherwise falling back to disabling interrupts.
> 
> Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Christoph Lameter <cl@xxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Pranith Kumar <bobby.prani@xxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: linux-arch@xxxxxxxxxxxxxxx
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> [Mark: backport to v3.16.y]

You sent 2 patches for 3.16.y, did you mean for one of these to be for
3.18.y?

thanks,

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]