Re: [PATCHv3] bcache: only permit to recovery read error when cache device is clean

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey Coly--

On Thu, Sep 21, 2017 at 12:54 PM, Coly Li <colyli@xxxxxxx> wrote:
> When bcache does read I/Os, for example in writeback or writethrough mode,
> if a read request on cache device is failed, bcache will try to recovery
> the request by reading from cached device. If the data on cached device is
> not synced with cache device, then requester will get a stale data.
[...]
> +       if (s->recoverable &&
> +           (dc && !atomic_read(&dc->has_dirty)) {

Looks like this is missing a parens.

Thx,

Mike



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]