On Thu, Oct 12, 2017 at 10:16:59AM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@xxxxxxxxx>
> Date: Thu, 12 Oct 2017 23:25:10 +0800
>
> > pls try revert:
> > commit 02f7e4101092b88e57c73171174976c8a72a3eba
> > Author: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Date: Mon Oct 2 12:20:51 2017 -0700
> >
> > socket, bpf: fix possible use after free
> >
> > which caused a obvious issue in __sk_attach_prog():
> > atomic_set(&fp->refcnt, 0); <----
> >
> > if (!sk_filter_charge(sk, fp)) {
> > kfree(fp);
> > return -ENOMEM;
> > }
>
> Yeah this is the bad patch, my backport was buggy.
>
> Greg, please revert.
No problem, I'll go revert it now.
Thanks to everyone for the good debugging and quick response.
greg k-h