Re: [PATCH for v4.4] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 11, 2017 at 10:22:40AM +0300, Luca Coelho wrote:
> From: Luca Coelho <luciano.coelho@xxxxxxxxx>
> 
> commit 97bce57bd7f96e1218751996f549a6e61f18cc8c upstream.
> 
> The MCAST_FILTER_CMD can get quite large when we have many mcast
> addresses to set (we support up to 255).  So the command should be
> send as NOCOPY to prevent a warning caused by too-long commands:
> 
> WARNING: CPU: 0 PID: 9700 at /root/iwlwifi/stack-dev/drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1550 iwl_pcie_enqueue_hcmd+0x8c7/0xb40 [iwlwifi]
> Command MCAST_FILTER_CMD (0x1d0) is too large (328 bytes)
> 
> This fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196743
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Luca Coelho <luciano.coelho@xxxxxxxxx>
> ---
>  drivers/net/wireless/iwlwifi/mvm/mac80211.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Thanks for the patch, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]