Re: [PATCH] intel-iommu: Flush unmaps at domain_exit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2013 at 09:10:38PM +0200, Willy Tarreau wrote:
> Hi Greg,
> 
> On Fri, Sep 06, 2013 at 11:26:52AM -0700, Greg KH wrote:
> > On Fri, Sep 06, 2013 at 11:26:18AM -0700, Greg KH wrote:
> > > On Fri, Sep 06, 2013 at 11:17:51PM +0530, Jitendra Bhivare wrote:
> > > > Backported Alex Williamson's commit to 2.6.32.y
> > > > http://git.kernel.org/linus/7b668357810ecb5fdda4418689d50f5d95aea6a8
> > > > 
> > > > It resolves the following assert when module is immediately reloaded.
> > > > 
> > > > kernel BUG at drivers/pci/iova.c:155!
> > > > <snip>
> > > > Call Trace:
> > > > [<ffffffff812645c5>] intel_alloc_iova+0xb5/0xe0
> > > > [<ffffffff8126725e>] __intel_map_single+0xbe/0x210
> > > > [<ffffffff812674ae>] intel_alloc_coherent+0xae/0x120
> > > > [<ffffffffa035f909>] be_queue_alloc+0xb9/0x140 [be2net]
> > > > [<ffffffffa035fa5a>] be_rx_qs_create+0xca/0x370 [be2net]
> > > > <snip>
> > > > 
> > > > The issue is reproducible in 2.6.32.60 and also gets resolved
> > > > by passing intel-iommu=strict to kernel.
> > > > 
> > > > Signed-off-by: Jitendra Bhivare <jitendra.bhivare@xxxxxxxxx>
> > > > ---
> > > >  drivers/pci/intel-iommu.c | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > 
> > > 
> > > <formletter>
> > > 
> > > This is not the correct way to submit patches for inclusion in the
> > > stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> > > for how to do this properly.
> > 
> > Doh, nevermind, you did this correctly, I need to go train my stable-bot
> > a bit better, sorry about that...
> 
> Jitendra originally sent it to me only so I asked that it was resent
> here with all the relevant info in the commit, though of course as this
> is a backport, I suspect the format might change a bit from what your
> bot is used to. Are there any specific things your bot looks at that we
> need to take care of in order to limit false positives ?

It looks at signed-off-by: lines, and subject lines, and missed the
"backport to 2.6.32" stuff in the top of the email.  It's now been
fixed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]