Re: [PATCH 4.9] powerpc/ftrace: Pass the correct stack pointer for DYNAMIC_FTRACE_WITH_REGS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 28, 2017 at 07:10:27PM +0530, Naveen N. Rao wrote:
> For DYNAMIC_FTRACE_WITH_REGS, we should be passing-in the original set
> of registers in pt_regs, to capture the state _before_ ftrace_caller.
> However, we are instead passing the stack pointer *after* allocating a
> stack frame in ftrace_caller. Fix this by saving the proper value of r1
> in pt_regs. Also, use SAVE_10GPRS() to simplify the code.
> 
> Fixes: 153086644fd1 ("powerpc/ftrace: Add support for -mprofile-kernel ftrace ABI")
> Cc: stable@xxxxxxxxxxxxxxx # v4.6+
> Signed-off-by: Naveen N. Rao <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
> ---
> Hi Greg,
> Here is the backported patch for upstream commit a4979a7e71eb8d 
> ("powerpc/ftrace: Pass the correct stack pointer for 
> DYNAMIC_FTRACE_WITH_REGS") for stable kernel v4.9. This has been tested 
> by Michael Ellerman. Kindly apply.

Thanks for the backport, now applied.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]