Re: [PATCH 3.10-stable] xen/arm: missing put_cpu in xen_percpu_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 23 Aug 2013, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.10-stable tree, should we apply
> it?

Yes, please.
Sorry for the very late reply.


> ------------------
> 
> From: "Julien Grall <julien.grall@xxxxxxxxxx>"
> 
> commit 0d7febe58413884f6428143221971618fbf3a47d upstream
> 
> When CONFIG_PREEMPT is enabled, Linux will not be able to boot and warn:
> [    4.127825] ------------[ cut here ]------------
> [    4.133376] WARNING: at init/main.c:699 do_one_initcall+0x150/0x158()
> [    4.140738] initcall xen_init_events+0x0/0x10c returned with preemption
> imbalance
> 
> This is because xen_percpu_init uses get_cpu but doesn't have the
> corresponding
> put_cpu.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Signed-off-by: Jonghwan Choi <jhbird.choi@xxxxxxxxxxx>
> ---
>  arch/arm/xen/enlighten.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c
> index 13609e0..05db95d 100644
> --- a/arch/arm/xen/enlighten.c
> +++ b/arch/arm/xen/enlighten.c
> @@ -170,6 +170,7 @@ static void __init xen_percpu_init(void *unused)
>  	per_cpu(xen_vcpu, cpu) = vcpup;
>  
>  	enable_percpu_irq(xen_events_irq, 0);
> +	put_cpu();
>  }
>  
>  static void xen_restart(char str, const char *cmd)
> -- 
> 1.7.
> 
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]