Re: [PATCH] netlink: do not proceed if dump's start() errs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] netlink: do not proceed if dump's start() errs
From: "Jason A. Donenfeld" <Jason@xxxxxxxxx>
Date: Wed, 27 Sep 2017 15:06:40 +0200
Cc: David Miller <davem@xxxxxxxxxxxxx>, Netdev <netdev@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <1506517514.2108.2.camel@sipsolutions.net>

On Wed, Sep 27, 2017 at 3:05 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> I guess you could change it to
>
> if (cb->start)
>         ret = cb->start(cb);
> if (!ret)
>         ret = netlink_dump(sk);

Very clean. I'll do it like that. I'll wait a bit longer before
submitting v2, but beyond that, seems sane to you?

Jason

References:
- [PATCH] netlink: do not proceed if dump's start() errs
  - From: Jason A. Donenfeld
- Re: [PATCH] netlink: do not proceed if dump's start() errs
  - From: Jason A. Donenfeld
- Re: [PATCH] netlink: do not proceed if dump's start() errs
  - From: Johannes Berg

Prev by Date: Re: [PATCH] netlink: do not proceed if dump's start() errs
Next by Date: Re: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN
Previous by thread: Re: [PATCH] netlink: do not proceed if dump's start() errs
Next by thread: [PATCH v2] seccomp: fix the usage of get/put_seccomp_filter() in seccomp_get_filter()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]