On Mon, Sep 25, 2017 at 08:53:07AM -0700, Christoph Hellwig wrote:
> > if (!q)
> > return ERR_PTR(-ENOMEM);
> > q->cmd_size = sizeof(struct bsg_job) + dd_job_size;
> > - q->init_rq_fn = bsg_init_rq;
> > - q->exit_rq_fn = bsg_exit_rq;
> > + q->init_rq_fn = bsg_init_job;
> > + q->exit_rq_fn = bsg_exit_job;
> > + q->initialize_rq_fn = bsg_init_rq;
>
> Please use function names that match the method names, that is keep
> the existing names and name the new helper bsg_initialize_rq;
>
OK, I can change that.
Beste Grüße / Best regards,
- Benjamin Block
>
> Except for that the patch looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>
--
Linux on z Systems Development / IBM Systems & Technology Group
IBM Deutschland Research & Development GmbH
Vorsitz. AufsR.: Martina Koederitz / Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294