Re: [char-misc 1/2] mei: always use domain runtime pm callbacks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



	On Mon, 2017-09-25 at 00:37 +0200, Rafael J. Wysocki wrote:
> On Sun, Sep 24, 2017 at 10:35 AM, Tomas Winkler <tomas.winkler@xxxxxxxxx> wrote:
> > From: Alexander Usyskin <alexander.usyskin@xxxxxxxxx>
> > 
> > This patch fixes a regression caused by the new changes
> > in the run wake handlers, pci_dev_run_wake() return true
> > when wake is possible from the software perspective
> > not whether it is actually enabled.
> 
> This isn't exactly accurate, because "run wake" used to mean "wakeup
> signals can be generated for this device in the working state of the
> system", so it could not be enabled or disabled before too.  It's just
> that the function returns "true" for (at least) some devices for which
> it used to return "false" (arguably incorrectly).
> 
> Other than that I agree with the patch.

Thanks for the correction, I will respin the patch with your
explanation.

Thanks
Tomas




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]