On Wed, Sep 20, 2017 at 04:58:53PM +0200, Greg KH wrote: > On Wed, Sep 20, 2017 at 08:20:13AM -0500, Bin Liu wrote: > > Hi Greg, > > > > On Wed, Sep 20, 2017 at 12:34:14PM +0200, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > > > > This is a note to let you know that I've just added the patch titled > > > > > > [PATCH] Revert "usb: musb: fix tx fifo flush handling again" > > > > > > to the 3.18-stable tree which can be found at: > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > > > The filename of the patch is: > > > revert-usb-musb-fix-tx-fifo-flush-handling-again.patch > > > and it can be found in the queue-3.18 subdirectory. > > > > > > If you, or anyone else, feels it should not be added to the stable tree, > > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > > > > From 817bdbb406234e405e01790dfc6fffd91a15367e Mon Sep 17 00:00:00 2001 > > > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Date: Wed, 20 Sep 2017 12:31:05 +0200 > > > Subject: [PATCH] Revert "usb: musb: fix tx fifo flush handling again" > > > > > > This reverts commit 98b91bfa5e478b9bf332f9f149b1c25ffd58f877 which is > > > commit 45d73860530a14c608f410b91c6c341777bfa85d upstream. > > > > > > It should not have been applied to the 3.18-stable tree at all. > > > > The original commit 45d73860530a14c608f410b91c6c341777bfa85d upstream > > does mention it is applicable to v4.4+, > > > > Cc: stable@xxxxxxxxxxxxxxx # v4.4+ > > > > but it doesn't have 'Fixes ...' line. > > > > What is the best format of a commit message to help to prevent this > > incident happen again? > > You did it right, I missed it when I was applying patches, sorry, my > fault. No worries. I guess every maintainer has their automation setup, so just wanted to check if there is anything in patch submission could be done better. Regards, -Bin.