RE: [PATCH RESEND] aacraid: Fix 2T+ drives on SmartIOC-2000

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Dave,
> 
> > Hi Christoph,
> >
> >> > +             if ((le32_to_cpu(dresp->status) == ST_OK) &&
> >> > +                     (le32_to_cpu(dresp->mnt[0].vol) != CT_NONE)) {
> >> > +                     _aac_probe_container2(context, fibptr);
> >> > +                     return;
> >>
> >>                 if (dresp->status == cpu_to_le32(ST_OK) &&
> >>                     dresp->mnt[0].vol != cpu_to_le32(CT_NONE)) {
> >>
> >
> > I've contemplated this all day, and it looked like sematics, but I
> > assume you were Indicating that the cpu_to_le32() of a constant is a
> > compiler issue, vs le32_to_cpu() is a runtime issue. If so, thanks! If
> > not could you elaborate ...
> 
> FWIW, I applied your patch as-is for consistency with the rest of the driver. I do
> prefer Christoph's version, though, but that can be a follow-on patch.
> 

Hi Martin,

If I'm right regarding Christph's intentions, and you seem to imply, which since I've been an LE person most of my life,  I will instill in my development team, and propose another patch to fix that ...

Thanks, -Dave




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]